Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share image functionality #556

Merged
merged 3 commits into from
Feb 25, 2023

Conversation

ramosmauricio
Copy link
Contributor

I added a share image functionality, when opening a photo we will now have two options, download and share.

the file is downloaded to the temporary directory and then shared with share_plus package.

thanks!

@jonjomckay jonjomckay merged commit 066d580 into jonjomckay:master Feb 25, 2023
@jonjomckay
Copy link
Owner

Thank you! I cleaned it up a bit before merging - I hope you don't mind.

I swapped the XFile usage to use the factory method that takes in a byte array, rather than having to download the file to a temporary location, and also wrapped the button in an AsyncButtonBuilder so the user has some feedback that the file is being downloaded before sharing.

@jonjomckay jonjomckay added this to the v3.0.0 milestone Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants