impl Stream and remove the "eager retry" logic

[loyd]

• Added a Stream instance.
• Replaced deprecated lints and methods.
• Removed repolling on Pending. It's a controversial change, but I don't understand why the lib contains that logic. Firstly, it's a pretty rare situation, but it adds extra CAS on every Pending. Secondly, it doesn't seem to be the library's responsibility (and It breaks our tests (WS pool with tricky logic)).

[jonhoo]

These are good changes, thank you! Left some notes inline.

Also, would you mind rebasing against master to pick up the CI changes I just made?

[jonhoo]

Looks good, thanks!

[codecov]

Codecov Report

Merging #1 (6f05015) into main (4bf517f) will increase coverage by 7.8%.
The diff coverage is 94.1%.

Additional details and impacted files

Impacted Files	Coverage Δ
src/lib.rs	94.2% <94.1%> (+7.8%)	⬆️

[jonhoo]

Looks like two CI failures. One is because the rustdoc lint hadn't yet been renamed in 1.51, which we still support, so its build fails. The other is because, seemingly, something in our dependency graph isn't truthfully representing their minimum required dependency versions. You may have to explicitly list async-stream-impl in our Cargo.toml with a higher version requirement (and perhaps send a PR to tokio-stream to bump its listed dependency version?).

[loyd]

@jonhoo, could you run lints? I want to fix them finally =)

[loyd]

tokio-rs/tokio#5347

[jonhoo]

Happy to merge this once we remove that now-unneeded line from Cargo.toml 🎉
I'll do a release shortly after.

[loyd]

So, are you waiting for the new release of tokio-test? The latest release was in May, this is not a quick process, sadly. I think specifying async-stream is good enough to make a release. Maybe the comment should be remove once tokio-test v0.4.3 is released =)

[jonhoo]

Ah, I thought they did a release after merging the PR. In that case just updating the comment is fine 👍

[jonhoo]

Released in 0.2.3 🎉 Thanks for sticking with it :)