-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Experimental Tango support #25
Draft
bazhenov
wants to merge
20
commits into
jonhoo:main
Choose a base branch
from
bazhenov:tango
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4504dcd
Tango benchmarks are added
bazhenov 6adc4fc
Benchmark workflow
bazhenov 31ff8f2
Using dev version of tango for diagnosing purposes
bazhenov 0204010
Remove unneeded nightly aligning directives
bazhenov 11c5741
Temporarly benching agains itself
bazhenov 6a1ad2c
Setting threshold to 20
bazhenov c315676
Trying no outliers filtering
bazhenov 1ef4a54
Some fixes in benchmarking harness
bazhenov 852fcf5
Updating versions to pass minimum versions test
bazhenov 5ca8152
Updating log dependency
bazhenov 8feb7b5
Rerun build script only if it was changed
bazhenov e1a5111
There is no more need of a dummy entrypoint
bazhenov 4f66478
Updating checkout action
bazhenov 9a264e1
Using dtolnay/rust-toolchain for Rust toolchain setup
bazhenov 677cbf6
Using cache to store cargo-export between runs
bazhenov 80ef080
Using lock files when generating benchmarks
bazhenov 157f2ea
hashFiles() only works inside GHA workspace directory
bazhenov c94550a
Shorter configuration
bazhenov 85b78bd
Updating tango-bench
bazhenov 5a56472
Using prebuilt version of cargo export and optimized rust cache
bazhenov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
name: Benchmarks | ||
|
||
permissions: | ||
contents: read | ||
|
||
on: | ||
pull_request: | ||
|
||
jobs: | ||
bench: | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/checkout@v4 | ||
with: | ||
ref: main | ||
path: baseline-branch | ||
|
||
- name: Install Toolchain | ||
uses: dtolnay/rust-toolchain@nightly | ||
|
||
- uses: Swatinem/rust-cache@v2 | ||
- uses: taiki-e/install-action@v2 | ||
with: | ||
tool: cargo-export | ||
|
||
- name: cargo generate-lockfile | ||
if: hashFiles('Cargo.lock') == '' | ||
run: cargo generate-lockfile | ||
- name: Building Benchmarks | ||
run: | | ||
cargo export target/benchmarks -- bench --bench=search_ord --locked | ||
# !!!SHOULD BE FIXED AFTER MERGE TO MAIN!!! | ||
# At the moment we can only test branch agains itself, because there is no | ||
# tango benchmarks on the main. | ||
# cd baseline-branch | ||
# cargo export target/benchmarks -- bench --bench=search_ord --locked | ||
|
||
- name: Run Benchmarks | ||
run: | | ||
set -eo pipefail | ||
|
||
target/benchmarks/search_ord --color=never compare target/benchmarks/search_ord \ | ||
-ot 1 --fail-threshold 10 | tee target/benchmark.txt | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
More on cli-arguments |
||
|
||
- uses: actions/upload-artifact@v3 | ||
with: | ||
name: benchmark.txt | ||
path: target/benchmark.txt |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think several of these could probably be improved upon by drawing from other helpful GitHub actions. For example, installing Rust and installing crate-binaries have pretty good (and more optimized) variants. The other workflow files may be able to provide some inspiration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dtolnay/rust-toolchain
taiki-e/install-action
to cargo-export