Skip to content

Conversation

@Sciencentistguy
Copy link
Contributor

Clap v3 has merged structopt directly into clap, and structopt itself is now in maintenance-only mode.

This PR switches all use of structopt over to clap's new #[derive(Parser)].

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #227 (90ecf8e) into master (502c8f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files          17       17           
  Lines        2381     2381           
=======================================
  Hits         2072     2072           
  Misses        309      309           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502c8f3...90ecf8e. Read the comment docs.

@jonhoo
Copy link
Owner

jonhoo commented Jan 8, 2022

Thanks for taking the time to do this! It looks like this ends up bumping the MSRV, which I think is okay for this change, but we should update CI to match the new required version 👍

minrust: 1.46.0

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@jonhoo
Copy link
Owner

jonhoo commented Jan 9, 2022

Actually, before I merge, cc @djc for cargo-flamegraph to see how problematic this would be there. I think the move to clap3 is pretty worthwhile.

@djc
Copy link
Contributor

djc commented Jan 9, 2022

Should be fine, we already ported flamegraph (which now disables the cli feature in inferno). I'm discussing the MSRV issue upstream.

@jonhoo jonhoo merged commit b090972 into jonhoo:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants