forked from dotnet/android
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Xamarin.Android.Build.Tasks] r8 duplicate resource warnings -> messa…
…ges (dotnet#4001) Fixes: dotnet#3622 Context: https://r8.googlesource.com/r8/ Just building a Xamairn.Forms template with multi-dex enabled produces the warning: R8 : warning : Resource 'META-INF/MANIFEST.MF' already exists. There are also other reports of: R8 : warning : Resource 'META-INF/MSFTSIG.SF' already exists. R8 : warning : Resource 'META-INF/MSFTSIG.RSA' already exists. Reviewing r8's source code, I see no way to prevent it from emitting these messages. For now, it seems simple enough to add a `Regex` for this message and downgrade it to a regular MSBuild message. I added a test for this scenario as well, however I was also getting this message from r8: Warning: The rule `-keep public class * extends java.lang.annotation.Annotation { *; }` uses extends but actually matches implements. I don't think we should downgrade this one, yet... I reworked the test so allow 1 warning and used a property to disable a warning coming from Xamarin.Build.Download.
- Loading branch information
1 parent
6e40a8f
commit 92bc705
Showing
2 changed files
with
36 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters