fix(lib/get_navigation): Improve preventDuplicates and preventDuplicateHandlingMode in navigator2 #3262
+79
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix: #3261 |
1. using preventDuplicates option of Get Navigation
- to、off、offNamed、offUntil、backAndtoNamed、
- toNamed、offNamedUntil、toNamedAndOffUntil
2. merge preventDuplicates option in _configureRouterDecoder API
3. execute _activePages.add(res) when route.preventDuplicates == false
linpengteng
changed the title
jonataslaw
requested changes
Feb 11, 2025
| @@ -690,6 +691,7 @@ extension GetNavigationExt on GetInterface { | |||
| String? id, | |||
| dynamic arguments, | |||
| Map<String, String>? parameters, | |||
| bool preventDuplicates = true, | |||
There was a problem hiding this comment.
Maybe this value should be false by default
| @@ -629,6 +629,7 @@ extension GetNavigationExt on GetInterface { | |||
| dynamic arguments, | |||
| String? id, | |||
| Map<String, String>? parameters, | |||
| bool preventDuplicates = true, | |||
| @@ -702,6 +704,7 @@ extension GetNavigationExt on GetInterface { | |||
| id: id, | |||
| arguments: arguments, | |||
| parameters: parameters, | |||
| preventDuplicates: preventDuplicates, | |||
| @@ -722,6 +725,7 @@ extension GetNavigationExt on GetInterface { | |||
| String? id, | |||
| dynamic result, | |||
| Map<String, String>? parameters, | |||
| bool preventDuplicates = true, | |||
| @@ -1003,11 +1008,13 @@ extension GetNavigationExt on GetInterface { | |||
| bool Function(GetPage) predicate, [ | |||
| Object? arguments, | |||
| String? id, | |||
| bool preventDuplicates = true, | |||
| String page, { | ||
| T? result, | ||
| Object? arguments, | ||
| bool preventDuplicates = true, |
| @@ -521,9 +527,13 @@ class GetDelegate extends RouterDelegate<RouteDecoder> | |||
| dynamic arguments, | |||
| String? id, | |||
| Map<String, String>? parameters, | |||
| bool preventDuplicates = true, | |||
| @@ -541,9 +551,13 @@ class GetDelegate extends RouterDelegate<RouteDecoder> | |||
| dynamic arguments, | |||
| String? id, | |||
| Map<String, String>? parameters, | |||
| bool preventDuplicates = true, | |||
| @@ -554,10 +568,14 @@ class GetDelegate extends RouterDelegate<RouteDecoder> | |||
| String page, | |||
| bool Function(GetPage) predicate, [ | |||
| Object? data, | |||
| bool preventDuplicates = true, | |||
| @@ -573,12 +591,17 @@ class GetDelegate extends RouterDelegate<RouteDecoder> | |||
| Widget Function() page, | |||
| bool Function(GetPage) predicate, [ | |||
| Object? arguments, | |||
| bool preventDuplicates = true, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support merge preventDuplicateHandlingMode by copyWith (GetPage)
add and using preventDuplicates option of Getx5 Navigator2 API
merge preventDuplicates option in _configureRouterDecoder API
execute _activePages.add(res) when route.preventDuplicates == false
Pre-launch Checklist