Remove ExpressionParser and use the amazing RuboCop::AST::NodePattern #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
|
SourceLevel has finished reviewing this Pull Request and has found:
|
|
@jonatas Do you plan to merge this? |
|
Hi @andriy-baran, thank you for showing interest in this! I made it on a weekend and never pushed it again to the upstreaming changes. I'll not merge it too soon as I need some time to catch up with the latest expression of the rubocop-ast news and guarantee it will be fully compatible. If you have the time to move on, feel free to rebase I'll be happy to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RuboCop AST is finally isolated into a separated gem and now we don't need to keep the core of the library as NodePattern is pretty much stable and easy to use.
It also validates syntaxes of the expression and had a slightly different behavior on
...operator.Basically symbols needs explicitly call with
:.nilbecomesnil?in most part of the cases and the.something?is justsomething?now ;)Kudos to @marcandre for extracting it from RoboCop. My first attempt failed and he simply did it 🚀