Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add glob support for nomad jobs defaulting to **/*.nomad #12

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

prabirshrestha
Copy link
Contributor

This adds support for glob pattern for nomad jobs which is breaking if you set it in the past. I had README.md file and it was trying to submit a job. This would also allow us to organize inside a folder.

This would also lay as a foundation for adding support for nomad variables.

jobs/traefik/README.md
jobs/traefik/traefik.nomad
jobs/traefik/traefik.nomad.vars.hcl

Currently not a fan of the name --path after this change. I'm thinking --nomad-jobs jobs/**/*.nomad.hcl --nomad-vars jobs/**/*.nomad.vars.hcl. I explicitly prefixed with nomad since in future it might make sense to add waypoint to support this use case. Thoughts on this change or can do later when I send variables PR later.

I have set the default path to be **/*.nomad. And also updated the README.md examples so it works for those who copy paste to try it out.

@jonasvinther jonasvinther merged commit 41b1216 into jonasvinther:main Aug 3, 2023
1 check passed
@prabirshrestha prabirshrestha deleted the glob branch August 3, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants