fix deprecation warnings in Elixir 1.9.0 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 4, 2019
Closed
|
Can someone merge and release this, please? This is basically preventing us from upgrading our projects to Elixir 1.9.0, because a ton of warnings are emitted when running our tests. |
|
yes please merge! Same issue as @woylie: can't upgrade to 1.9.0 because of this issue. Thanks for the PR! |
|
guys can we get this merged soon please? 🙏 👍 |
|
It'd be very helpful if you could please get this PR merged! |
|
@jonasschmidt any update on this? |
|
Sorry for the long delay. I was on sabbatical and had my GitHub email still set to the company address, so I never got the notifications for the open issues. The PR has been merged and released in version |
|
Thanks for merging! |
luizParreira
pushed a commit
to luizParreira/event-validator
that referenced
this pull request
Oct 6, 2019
- This was done in order to fix the warnings generated by elixir 1.9. See: jonasschmidt/ex_json_schema#43
luizParreira
pushed a commit
to luizParreira/event-validator
that referenced
this pull request
Oct 12, 2019
- This was done in order to fix the warnings generated by elixir 1.9. See: jonasschmidt/ex_json_schema#43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.