Allow to generate a compilation database #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krobelus
commented
Dec 31, 2020
koutcher
reviewed
Dec 31, 2020
Makefile
Outdated
Comment on lines
411
to
437
| GENERATE_COMPILATION_DATABASE ?= no | ||
|
|
||
| ifeq ($(GENERATE_COMPILATION_DATABASE),yes) | ||
| compdb_check = $(shell $(CC) $(ALL_CFLAGS) \ | ||
| -c -MJ /dev/null \ | ||
| -x c /dev/null -o /dev/null 2>&1; \ | ||
| echo $$?) | ||
| ifneq ($(compdb_check),0) | ||
| override GENERATE_COMPILATION_DATABASE = no | ||
| $(warning GENERATE_COMPILATION_DATABASE is set to "yes", but your compiler does not \ | ||
| support generating compilation database entries) | ||
| endif | ||
| else | ||
| ifneq ($(GENERATE_COMPILATION_DATABASE),no) | ||
| $(error please set GENERATE_COMPILATION_DATABASE to "yes" or "no" \ | ||
| (not "$(GENERATE_COMPILATION_DATABASE)")) | ||
| endif | ||
| endif | ||
|
|
||
| compdb_dir = compile_commands | ||
| ifeq ($(GENERATE_COMPILATION_DATABASE),yes) | ||
| compdb_file = $(compdb_dir)/$(subst /,-,[email protected]) | ||
| compdb_args = -MJ $(compdb_file) | ||
| else | ||
| compdb_args = | ||
| endif | ||
|
|
There was a problem hiding this comment.
Move this part at line 88 to make $(missing_compdb_dir) work.
There was a problem hiding this comment.
Yep, thanks! I'm not sure why because I don't see where the order would matter but that's okay 🤷
Taken from Git's Makefile. Keep in mind that not all compilers support the -MJ option. Clang does, so this command should give you a fresh compile_commands.json make CC=clang GENERATE_COMPILATION_DATABASE=yes clean all-debug
krobelus
force-pushed
the
generate-compile_commands.json
branch
from
0243059 to
c456645
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for some Clang-based tools, in particular language servers like clangd or ccls.
I mostly took this mostly from Git's Makefile. The awkward if-statement
is because the "missing_compdb_dir" trick that Git uses didn't work for
some reason.
Keep in mind that not all compilers support the -MJ option. Clang does, so this
command should give you a fresh compile_commands.json