Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untracked files not shown #1219

Closed
rsignavong opened this issue Jul 18, 2022 · 5 comments
Closed

Untracked files not shown #1219

rsignavong opened this issue Jul 18, 2022 · 5 comments

Comments

@rsignavong
Copy link

Untracked files are not shown even with

set status-show-untracked-dirs	= yes		# Show files in untracked directories? (status)
set status-show-untracked-files	= yes		# Show untracked files?

in my .tigrc file

TIG version:

> tig --version
tig version 2.5.6
ncursesw version 6.3.20211021
readline version 8.1

OS:
MacOS Monterey 12.4
M1 Apple Chip

@von
Copy link

von commented Jul 19, 2022

I'm also seeing this problem. If I set status-show-untracked-dirs = yes after tig starts, it works as expected or if I set it via a script and TIG_SCRIPT it works on startup, but any setting in .tigrc seems to be completely ignored.

@koutcher
Copy link
Collaborator

2.5.6 fixed the reading of status.showuntrackedfiles from git config. Values from git config override the values in .tigrc.

@von
Copy link

von commented Aug 18, 2022

So, I did confirm that with 2.5.6 having showUntrackedFiles = true in git config causes tig to behave as expected.

But as I read the git-config documentation, the allowed values for showUntrackedFiles are no/normal/all and not true/false, but tig seems to treat all those values as false.

It seems like tig should be treating normal or all for showUntrackedFiles as true.

@koutcher
Copy link
Collaborator

Agreed, not only the name needed to be fixed, the parsing as well.

koutcher added a commit to koutcher/tig that referenced this issue Aug 19, 2022
status.showUntrackedFiles was incorrecly parsed as a boolean. According
to git-config(1), possible values are `no`, `normal` and `all`.

Fixes jonas#1219
von added a commit to von/homestuff that referenced this issue Aug 31, 2022
@von
Copy link

von commented Sep 1, 2022

Confirming fixed in 2.5.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants