Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status line is inaccurate when changing line-graphics #1163

Closed
gareth opened this issue Nov 12, 2021 · 1 comment · Fixed by #1164
Closed

Status line is inaccurate when changing line-graphics #1163

gareth opened this issue Nov 12, 2021 · 1 comment · Fixed by #1164

Comments

@gareth
Copy link

gareth commented Nov 12, 2021

When I change line graphics mode by pressing ~, the status line reports the change:

image

However, if I actually try to use this configuration command, either directly in the app (via :set main-view-line-graphics = …) or via a config line in .tigrc, I'm given the error message Failed to parse view column type: …:

image

Instead, I'm able to get this working by setting the config key line-graphics, but as a very casual user I don't know if I'm intended to be able to do it both ways.

@koutcher
Copy link
Collaborator

koutcher commented Nov 12, 2021

Thanks for reporting the issue. This is a regression introduced by 80b40c2 in 2.5.0. #944 should have been restricted to column options.

koutcher added a commit to koutcher/tig that referenced this issue Nov 12, 2021
koutcher added a commit to koutcher/tig that referenced this issue Nov 13, 2021
koutcher added a commit to koutcher/tig that referenced this issue Nov 20, 2021
koutcher added a commit that referenced this issue Jan 4, 2022
The regression was introduced by #944 in 80b40c2.

Fixes #1163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants