feat(taiko impl): Add Taiko Rust implementation of Jacobi symbol#3
Merged
Conversation
Owner
|
Nice! Thanks for the contribution, and sorry I missed this until now. I'll check out the code and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
I stumbled across your paper https://eprint.iacr.org/2024/1054.pdf and want to add my optimized Jacobi implementation in Rust.
Writeup: mratsim/constantine#199
Rust impl: privacy-ethereum/halo2curves#95
Benchmarks
On 256 bits, this is a 25x acceleration over the baseline and 7.8x acceleration over your new algorithm.
On 384 bits, this is a 24x / 7.15x acceleration
Change for generic large integer
Currently the implementation is specialized for compile-time size but it should be easy to change the array buffer to use a Vec instead.
One last optimization would be to use in-place mutation as with heap-allocated Vec the compiler cannot do the same optimization as stack allocated arrays.