Add SQL Server support #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgeorge
force-pushed
the
sql_server
branch
6 times, most recently
from
eca600b to
e3dd312
Compare
jonahgeorge
force-pushed
the
sql_server
branch
2 times, most recently
from
e10941b to
90f7967
Compare
jonahgeorge
force-pushed
the
sql_server
branch
7 times, most recently
from
09a7b3d to
5406cd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds minimal support for SQL Server (similar to SQLite, without day_start or timezone support) .
I originally went down the path of attempting time zone support via the
SWITCHOFFSETmethod withActiveSupport::TimeZone#formatted_offset; however, when considering older dates this was not accounting for DST (WIP here).Instead, it appears to properly support timezones one would need to use the
AT TIME ZONEoperator; however, SQL Server requires Windows timezone names and outside of CLDR I have not found a maintained mapping.Callouts:
@@DATEFIRSTis required to be considered when doing week-math as MSSQL allows one to configure what the start of the week is.Blocked by: