Skip to content

Conversation

@eczmustafa
Copy link

a temporary workaround about the issue #573

a temporary workaround about the issue joltup#573
@halaei
Copy link

halaei commented Jan 25, 2022

Your change only fixes one case.
The correct way is toLowerCase(Locale.ENGLISH) or toLowerCase(Locale.ROOT)
Please also consider sending your PR to https://github.com/RonRadtke/react-native-blob-util

@eczmustafa
Copy link
Author

thank you for the new link.
toLowerCase(Locale.ENGLISH) should work in theory and this is the professinal way of doing it. yes you right. however, this issue needs to be resolved, ihmo, by manually replacing dotless i (0x131), unfortunately.

On a linux pc these lines give same results:
String txt="ŞĞÜİI";
System.out.println("Locale.ENGLISH: " + txt.toLowerCase(Locale.ENGLISH));
System.out.println("Locale.ROOT: " + txt.toLowerCase(Locale.ROOT));
System.out.println("tr-TR: " + txt.toLowerCase(new Locale("tr-TR")));
System.out.println("default: " + txt.toLowerCase());

Output:
Locale.ENGLISH: şğüi̇i
Locale.ROOT: şğüi̇i
tr-TR: şğüi̇i
default: şğüi̇i

I don't have opportunity to test on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants