Fix for Python 3 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.djangoproject.com/en/1.5/topics/http/shortcuts/ "content_type Changed in Django 1.5: This parameter used to be called mimetype."
|
This is great, can we add a tests and a test matrix to make sure it works with the supported version of Django? We probably want to make it explicit on the README too. |
PetrDlouhy
force-pushed
the
master
branch
4 times, most recently
from
527e533 to
618ecb0
Compare
|
Now it comes with the Travist testing and Coveralls coverage reports. You will have to enable it for the main repository. |
|
Apparently as this repositiory is not in an org, I cannot do it myself. @jojax can you do it? |
| - pip install -q "$DJANGO_VERSION" | ||
| - python setup.py install | ||
| script: | ||
| - coverage run manage.py test --settings=settings |
There was a problem hiding this comment.
When trying to run this locally I get a No file to run: 'manage.py' error.
Would you mind also adding a tox.ini file?
There was a problem hiding this comment.
Nevermind it just works:
$ coverage run manage.py test --settings=settings
Creating test database for alias 'default'...
ERROR Got error:
details: Description of the error by the browser javascript engine.
user: <UNAUTHENTICATED>
..
----------------------------------------------------------------------
Ran 2 tests in 0.030s
OK
Destroying test database for alias 'default'...
|
First of all thanks @PetrDlouhy for your work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on PR #7