Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve project "Implicit conversion loses integer precision: ..." warnings #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ftronnbe
Copy link

Description

Warnings like

⚠️ Implicit conversion loses integer precision: 'long' to 'bufsize_t' (aka 'int')

began showing up in Xcode 13. This PR makes such implicit conversions explicit. Technically the additions in this PR effectively silence these warnings.

What to test

Nothing really. This just makes the conversion more explicit.

…ready.

This will get rid of project warnings.
@gongzhang
Copy link

Are you using Swift Package Manager? I think cLanguageStandard should be add to the Package.swift manifest to keep consistent with the xproj file. No need to modify cmark source code.

image

@gongzhang
Copy link

Are you using Swift Package Manager? I think cLanguageStandard should be add to the Package.swift manifest to keep consistent with the xproj file. No need to modify cmark source code.

image

Sorry. The warnings are still there after adding cLanguageStandard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants