Disabling Tests #84
Merged
Disabling Tests #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkary
reviewed
Apr 30, 2021
| protected function isSlow(int $time, int $slowThreshold): bool | ||
| { | ||
| return $time >= $slowThreshold; | ||
| return $time && $time >= $slowThreshold; |
Owner
There was a problem hiding this comment.
This line should first check $slowThreshold instead of $time. I'll fix this in master after merging the PR.
return $slowThreshold && $time >= $slowThreshold;
Owner
|
@MGatner Thanks for this PR! The PR as proposed doesn't quite work as intended, but it's an easy fix after I merge this. See inline comment above. This feature will be included in the next major release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to disable individual tests by setting the
@slowThresholdannotation to0.This was referenced in a few other issues and something I would use a lot. I think this is the cleanest approach but let me know if you would prefer an alternate annotation, like
@disableThreshold.