Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/Repeat list heading on new page #472

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Fernando-hub527
Copy link
Collaborator

Description
This feature allows the creation of lists with a fixed header through a method available in the list component. This method receives an instance of Maroto and uses this instance to add the list to the PDF with the fixed header.

Related Issue
#130

Checklist

check with "x", ONLY IF APPLIED to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • All mocks created with m := mocks.NewConstructor(t).
  • All mocks using m.EXPECT().MethodName() method to mock methods.
  • Updated docs/doc.go and docs/*
  • Updated example_test.go.
  • Updated README.md
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.27%. Comparing base (da3191b) to head (232c2f0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
+ Coverage   87.09%   87.27%   +0.19%     
==========================================
  Files          61       62       +1     
  Lines        2331     2364      +33     
==========================================
+ Hits         2030     2063      +33     
  Misses        268      268              
  Partials       33       33              
Flag Coverage Δ
unittests 87.27% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fernando-hub527
Copy link
Collaborator Author

@johnfercher conflicts fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants