Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake tests #333

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix flake tests #333

merged 1 commit into from
Oct 4, 2023

Conversation

johnfercher
Copy link
Owner

Description

Related Issue

  • fix flake tests on MacBook

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2cafb63) 35.85% compared to head (28f8441) 35.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2     #333   +/-   ##
=======================================
  Coverage   35.85%   35.85%           
=======================================
  Files          42       42           
  Lines        1445     1445           
=======================================
  Hits          518      518           
  Misses        908      908           
  Partials       19       19           
Flag Coverage Δ
unittests 35.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit 62f4191 into v2 Oct 4, 2023
5 checks passed
@johnfercher johnfercher deleted the v2-fix-flake-test branch October 4, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant