Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image #327

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Refactor image #327

merged 1 commit into from
Oct 1, 2023

Conversation

johnfercher
Copy link
Owner

Description

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fd3b1b0) 31.60% compared to head (6f0b638) 32.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #327      +/-   ##
==========================================
+ Coverage   31.60%   32.10%   +0.51%     
==========================================
  Files          19       19              
  Lines         937      944       +7     
==========================================
+ Hits          296      303       +7     
  Misses        634      634              
  Partials        7        7              
Flag Coverage Δ
unittests 32.10% <93.75%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/code/code.go 89.75% <100.00%> (+2.25%) ⬆️
internal/image.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit 10de07b into v2 Oct 1, 2023
5 checks passed
@johnfercher johnfercher deleted the v2-refactor-image branch October 1, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant