Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 remove gofpdf margin dimensions get #317

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

johnfercher
Copy link
Owner

Description

  • V2 remove gofpdf margin dimensions get
    Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@johnfercher johnfercher merged commit b145241 into v2 Sep 27, 2023
3 checks passed
@johnfercher johnfercher deleted the v2-remove-gofpdf-margin-dimensions-get branch September 27, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant