Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-162, add method to get total number of pages #167

Closed
wants to merge 1 commit into from

Conversation

happsie
Copy link
Contributor

@happsie happsie commented Mar 6, 2021

Description
Adds a PageCount to maroto. Useful for adding conditions
Related Issue
Resolves #162

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed go fmt github.com/johnfercher/maroto/... to format all files

@codecov-io
Copy link

Codecov Report

Merging #167 (5fc41e3) into master (0d2e5af) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   97.08%   97.09%   +0.01%     
==========================================
  Files           9        9              
  Lines         547      548       +1     
==========================================
+ Hits          531      532       +1     
  Misses         12       12              
  Partials        4        4              
Impacted Files Coverage Δ
pkg/pdf/pdf.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2e5af...5fc41e3. Read the comment docs.

@johnfercher
Copy link
Owner

Hello, the GetCurrentPage method doesn't do the same thing?

@happsie
Copy link
Contributor Author

happsie commented May 2, 2021

@johnfercher sorry for late reply, totally missed this!
I though that would do too. But since this issue came up I thought that the requester had come up with a special case in his work when this would actually be needed. Might close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A method to get the total number of pages?
4 participants