Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Add Page #147

Merged
merged 1 commit into from
May 16, 2020
Merged

Implement Add Page #147

merged 1 commit into from
May 16, 2020

Conversation

johnferchermeli
Copy link
Contributor

@johnferchermeli johnferchermeli commented May 14, 2020

Description

  • Implement Add Page

Related Issue
resolves #141

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed go fmt github.com/johnfercher/maroto/... to format all files

@codecov-io
Copy link

codecov-io commented May 14, 2020

Codecov Report

Merging #147 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   96.24%   96.29%   +0.06%     
==========================================
  Files           9        9              
  Lines         584      592       +8     
==========================================
+ Hits          562      570       +8     
  Misses         16       16              
  Partials        6        6              
Impacted Files Coverage Δ
pkg/pdf/pdf.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ad35b...1d1396b. Read the comment docs.

@johnfercher johnfercher merged commit 9add775 into master May 16, 2020
@johnfercher johnfercher deleted the feature/add-page branch May 16, 2020 16:29
felix pushed a commit to felix/maroto that referenced this pull request May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a custom page break command
3 participants