Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add width parameter in col #139

Merged
merged 13 commits into from
Mar 28, 2020
Merged

Conversation

johnferchermeli
Copy link
Contributor

@johnferchermeli johnferchermeli commented Feb 21, 2020

Description

  • Width parameter works like bootstrap
  • Adapt all components to work with the new version
  • Updates docs;

Related Issue
resolves #129

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed go fmt github.com/johnfercher/maroto/... to format all files

* Width parameter works like bootstrap
* Adapt Image to work with the new version
@johnferchermeli johnferchermeli force-pushed the feature/customizable-col-width branch from 1a768eb to b0c8c39 Compare March 23, 2020 18:45
@johnferchermeli johnferchermeli force-pushed the feature/customizable-col-width branch from b335028 to 523d881 Compare March 28, 2020 00:42
@codecov-io
Copy link

codecov-io commented Mar 28, 2020

Codecov Report

Merging #139 into master will increase coverage by 1.23%.
The diff coverage is 95.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   95.00%   96.22%   +1.23%     
==========================================
  Files           9        9              
  Lines         559      582      +23     
==========================================
+ Hits          531      560      +29     
+ Misses         22       16       -6     
  Partials        6        6              
Impacted Files Coverage Δ
internal/tablelist.go 67.86% <63.64%> (+9.53%) ⬆️
internal/text.go 93.34% <95.00%> (-6.66%) ⬇️
internal/code.go 100.00% <100.00%> (ø)
internal/image.go 100.00% <100.00%> (ø)
internal/math.go 100.00% <100.00%> (ø)
internal/signature.go 100.00% <100.00%> (ø)
pkg/pdf/pdf.go 100.00% <100.00%> (+1.47%) ⬆️
pkg/props/prop.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c95da...8a9c2d9. Read the comment docs.

@johnferchermeli johnferchermeli force-pushed the feature/customizable-col-width branch from 09ed3db to 89803ff Compare March 28, 2020 01:11
@johnferchermeli johnferchermeli force-pushed the feature/customizable-col-width branch from bcff61d to 7701dcb Compare March 28, 2020 01:33
@johnferchermeli johnferchermeli force-pushed the feature/customizable-col-width branch from a10b167 to 61f3add Compare March 28, 2020 13:57
@johnferchermeli johnferchermeli force-pushed the feature/customizable-col-width branch from 61f3add to 8a9c2d9 Compare March 28, 2020 14:20
@johnfercher johnfercher merged commit 34ad35b into master Mar 28, 2020
@johnfercher johnfercher deleted the feature/customizable-col-width branch March 28, 2020 15:39
felix pushed a commit to felix/maroto that referenced this pull request May 2, 2022
…ble-col-width

Add width parameter in col
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define column widths on both Col and TableList component
3 participants