Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in alternated background #138

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Fix bug in alternated background #138

merged 1 commit into from
Feb 21, 2020

Conversation

johnferchermeli
Copy link
Contributor

@johnferchermeli johnferchermeli commented Feb 21, 2020

Description

  • Expand header and footer behavior to simulate a margin top
  • Add guard closure in header and footer to turn background white

Related Issue
resolves #137

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed go fmt github.com/johnfercher/maroto/... to format all files

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #138 into master will decrease coverage by 0.33%.
The diff coverage is 90.63%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #138      +/-   ##
========================================
- Coverage   95.32%    95%   -0.32%     
========================================
  Files           9      9              
  Lines         534    559      +25     
========================================
+ Hits          509    531      +22     
- Misses         21     22       +1     
- Partials        4      6       +2
Impacted Files Coverage Δ
pkg/pdf/pdf.go 98.54% <90.63%> (-1.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 824b357...b636d7c. Read the comment docs.

* Expand header and footer behavior to simulate a margin top
* Add guard closure in header and footer to turn background white
@johnfercher johnfercher merged commit 10c95da into master Feb 21, 2020
@johnfercher johnfercher deleted the fix/background branch February 21, 2020 20:20
felix pushed a commit to felix/maroto that referenced this pull request May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AlternatedBackground doesn't work with custom top margin
3 participants