Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-124, add Line property to TableList. #125

Merged

Conversation

happsie
Copy link
Contributor

@happsie happsie commented Dec 20, 2019

The Line property will draw a Line after every content-row added to the list. The default spaceHeight is set to 1.0

Description

The Line property will draw a Line after every content-row added to the list. The default spaceHeight is set to 1.0

Skärmavbild 2019-12-20 kl  23 39 52

Related Issue

Resolves #124

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods has comments upside them explaining what it does
  • Executed go fmt github.com/johnfercher/maroto/... to format all files

The Line property will draw a Line after every content-row added to the list. The default spaceHeight is set to 1.0
@happsie happsie force-pushed the feature/ISSUE-124-add-line-to-tablelist branch from 82e0cd6 to 04e9551 Compare December 20, 2019 23:08
@codecov-io
Copy link

Codecov Report

Merging #125 into dev will increase coverage by 0.41%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #125      +/-   ##
==========================================
+ Coverage   94.81%   95.22%   +0.41%     
==========================================
  Files           9        9              
  Lines         520      522       +2     
==========================================
+ Hits          493      497       +4     
+ Misses         22       21       -1     
+ Partials        5        4       -1
Impacted Files Coverage Δ
pkg/props/prop.go 100% <ø> (ø) ⬆️
internal/tablelist.go 55.36% <100%> (+5.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0988a34...04e9551. Read the comment docs.

@happsie happsie marked this pull request as ready for review December 20, 2019 23:09
@johnfercher
Copy link
Owner

Very good, I will merge :)

@johnfercher johnfercher merged commit 73e20ce into johnfercher:dev Dec 20, 2019
@johnfercher johnfercher mentioned this pull request Dec 20, 2019
felix pushed a commit to felix/maroto that referenced this pull request May 2, 2022
…-line-to-tablelist

ISSUE-124, add Line property to TableList.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants