Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/go1.13.3 #110

Merged
merged 11 commits into from
Oct 25, 2019
Merged

feature/go1.13.3 #110

merged 11 commits into from
Oct 25, 2019

Conversation

BalajiTechs
Copy link
Contributor

@BalajiTechs BalajiTechs commented Oct 24, 2019

Description
Initial attempt to upgrade go to latest version

Related Issue
resolve #108

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • New public methods has comments upside them explaining what it does
  • Executed go fmt github.com/johnfercher/maroto/... to format all files

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files           8        8           
  Lines         473      473           
=======================================
  Hits          465      465           
  Misses          4        4           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3883f87...099d20e. Read the comment docs.

@SuddenGunter
Copy link
Collaborator

@BalajiTechs pls change target branch to dev

@BalajiTechs BalajiTechs changed the base branch from master to dev October 25, 2019 01:51
@BalajiTechs
Copy link
Contributor Author

@BalajiTechs pls change target branch to dev

Done.

@SuddenGunter SuddenGunter merged commit 3980139 into johnfercher:dev Oct 25, 2019
felix pushed a commit to felix/maroto that referenced this pull request May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants