feature/go-mod

[SuddenGunter]

switch to go modules

Description

• Switched from dep to go modules, as it must be in 2019.
  used this: https://blog.golang.org/migrating-to-go-modules
• Keep vendoring, just removed all left from dep and loaded new one with go mod vendor https://github.com/golang/go/wiki/Modules#how-do-i-use-vendoring-with-modules-is-vendoring-going-away
  @johnfercher do we really vendoring?

Related Issue
resolve #101

Checklist

• Updated README.md s

[johnfercher]

Keeping the vendor make the project retro compatible? If yes, I think we should keep saving the vendor.

[SuddenGunter]

Keeping the vendor make the project retro compatible

not sure
it's more like a holywar subject, but https://www.reddit.com/r/golang/comments/9ai79z/correct_usage_of_go_modules_vendor_still_connects/e4whe6l?utm_source=share&utm_medium=web2x
for me it seems more like a backup in case dependency went missing like left-pad in npm and also allows to freeze specific package version in vendor folder.
but
1 go.mod + go.sum allow to specify version of dependency
2 go modules proxy can be dependency backups storage even if dependency deleted from github
https://arslan.io/2019/08/02/why-you-should-use-a-go-module-proxy/

starting from 1.13 go get uses google modules proxy by default, so I think we can drop vendoring and it would be safe https://golang.org/doc/go1.13

IMHO vendoring more fits to languages without normal packaging system, like C 20 years ago. modern Go doesn't need it :)

[codecov-io]

Codecov Report

Merging #107 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #107   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files           8        8           
  Lines         473      473           
=======================================
  Hits          465      465           
  Misses          4        4           
  Partials        4        4

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43908ce...39c7bd9. Read the comment docs.

[marco-m]

Very happy to see Go modules here :-)
I agree with @SuddenGunter analysis, +1 to get rid of vendoring.