Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to py.test runner and assert keyword #80

Merged
merged 5 commits into from
Nov 18, 2015

Conversation

john-kurkowski
Copy link
Owner

  • Split the long test suite into a few shorter files.
  • No longer distribute tests. Those are handled centrally by CI now.
  • pytest-pylint plugin eliminates the need for tldextract/tests/lint.py.

py.test's automatic runner > hand-rolled test suite collection. Simple functions & assert keyword > JUnit-style OOP malarkey.

* Also fix Tox.
* No need to distribute tests. Those are centrally handled by CI now.
…odules pytest-dev/pytest#1057

That means no more testpaths option. Leverage .gitignore instead. Manually exclude setup.py and tldextract_app folder.
Eliminates the need for lint_test.py. Fixes Python 3.x "RuntimeError: dictionary changed size during iteration."

Continue to skip Pylint on yet-to-be-supported Python 3.5. Don't even try loading Pylint on 2.6; that's a SyntaxError.
@floer32
Copy link
Collaborator

floer32 commented Nov 16, 2015

🍻 Good stuff

john-kurkowski added a commit that referenced this pull request Nov 18, 2015
Switch to py.test runner and `assert` keyword
@john-kurkowski john-kurkowski merged commit 48df999 into master Nov 18, 2015
@john-kurkowski john-kurkowski deleted the refactor-to-py.test branch November 18, 2015 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants