tldextract --update can be configured to download private domains #65
Conversation
| @@ -281,7 +281,7 @@ def _add_extra_suffixes(self, suffixes): | |||
| return frozenset(suffixes) | |||
| return suffixes | |||
|
|
|||
| TLD_EXTRACTOR = TLDExtract() | |||
| TLD_EXTRACTOR = TLDExtract(include_psl_private_domains=True) | |||
There was a problem hiding this comment.
I like where this is going. I agree we must persist all public/private domains, but only include private results if the user opts into them. However this edit will include private domains for anybody who uses the export extract, just a few lines down. That would undo #19.
|
another try to fix #64 |
| @@ -374,12 +374,13 @@ def main(): | |||
| parser.add_argument('-c', '--cache_file', help='use an alternate TLD definition file') | |||
|
|
|||
| args = parser.parse_args() | |||
| tld_extract = TLDExtract(include_psl_private_domains=True) | |||
There was a problem hiding this comment.
Anybody who runs tldextract --update and later uses the same cache file will be forced to have public/private domains in their results, even if they only want public domains.
Ideally, we store metadata in the persisted file so results can be filtered at runtime.
For the 1.x series though, I think I'd be happy with include_psl_private_domains being configurable here.
There was a problem hiding this comment.
For the ideal fix, I opened #66.
There was a problem hiding this comment.
For the 1.x series though, I think I'd be happy with include_psl_private_domains being configurable here.
Bump. Sorry if it wasn't clear, this is the only blocker on this PR. Should be an easy update.
(I don't think anybody's gonna tackle #66 anytime soon. Don't hold your breath for it.)
|
Huh? |
|
If you make |
john-kurkowski
changed the title
tldextract --update can be configured to download private domains fixes #64
|
Thank you! |
fixes #64