Skip to content

Commit

Permalink
Tweak Sass styles
Browse files Browse the repository at this point in the history
After we have updated `ember-cli-sass` to `10`, the following warnings
started popping up:

```sh
WARNING: You probably don't mean to use the color value silver in interpolation here.
It may end up represented as silver, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "silver").
If you really want to use the color value here, use '"" + $color-name'.
```

This change will get rid of the warnings without changing the output
CSS.
  • Loading branch information
twokul authored and johanrd committed Feb 25, 2021
1 parent 00d8f88 commit 7fde4ce
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/dummy/app/styles/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ $colors: (
);

@each $color-name, $color-value in $colors {
.bg-#{$color-name} {
.bg-#{"" + $color-name} {
background-color: #{$color-value};
color: white;
}
.text-#{$color-name} {
.text-#{"" + $color-name} {
color: #{$color-value};
}
}
Expand Down

0 comments on commit 7fde4ce

Please sign in to comment.