Fix the issue: "Applications built using Odyssey's RibbonBar crash when switching users on W10" #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en switching users on W10"
The "This Freezable cannot be frozen" exception was caused by using
DynamicRessource on a <DrawingImage>. Static ressource must be used
instead. For instance:
<DrawingImage x:Key="{ComponentResourceKey odc:Skins, UpArrowImage}"
RenderOptions.BitmapScalingMode="HighQuality">
<DrawingImage.Drawing>
<DrawingGroup>
<GeometryDrawing Geometry="M5,3 L 3,1 L1,3 Z">
<GeometryDrawing.Pen>
<Pen Brush="{DynamicResource {ComponentResourceKey odc:Skins,
LightBorderBrush}}" Thickness="1" />
</GeometryDrawing.Pen>
</GeometryDrawing>
<GeometryDrawing Geometry="M4,2 L 2,0 L0,2 Z"
Brush="{DynamicResource {ComponentResourceKey odc:Skins,
RibbonForegroundBrush}}">
<GeometryDrawing.Pen>
<Pen Brush="{DynamicResource {ComponentResourceKey odc:Skins,
RibbonForegroundBrush}}"
Thickness="1" />
</GeometryDrawing.Pen>
</GeometryDrawing>
</DrawingGroup>
</DrawingImage.Drawing>
</DrawingImage>
Here brush properties are set by dynamic ressources, so they must be set
statically.
For instance:
<Pen Brush="{DynamicResource {ComponentResourceKey odc:Skins,
LightBorderBrush}}" Thickness="1" />
must be replaced by:
<Pen Brush="Black" Thickness="1" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "This Freezable cannot be frozen" exception was caused by using
DynamicRessource on a <DrawingImage>. Static ressource must be used
instead:
<DrawingImage x:Key="{ComponentResourceKey odc:Skins, UpArrowImage}" RenderOptions.BitmapScalingMode="HighQuality"> <DrawingImage.Drawing> <DrawingGroup> <GeometryDrawing Geometry="M5,3 L 3,1 L1,3 Z"> <GeometryDrawing.Pen> <Pen Brush="{DynamicResource {ComponentResourceKey odc:Skins, LightBorderBrush}}" Thickness="1" /> </GeometryDrawing.Pen> </GeometryDrawing> <GeometryDrawing Geometry="M4,2 L 2,0 L0,2 Z" Brush="{DynamicResource {ComponentResourceKey odc:Skins, RibbonForegroundBrush}}"> <GeometryDrawing.Pen> <Pen Brush="{DynamicResource {ComponentResourceKey odc:Skins, RibbonForegroundBrush}}" Thickness="1" /> </GeometryDrawing.Pen> </GeometryDrawing> </DrawingGroup> </DrawingImage.Drawing> </DrawingImage>Here brush properties are set by dynamic ressources, so they must be set statically:
<Pen Brush="{DynamicResource {ComponentResourceKey odc:Skins, LightBorderBrush}}" Thickness="1" />must be replaced by:
<Pen Brush="Black" Thickness="1" />