fix: Silence ECONNRESET errors after connection close

See also less/less.js#3693 Fixes tomas#391
joeyparrish · Mar 15, 2022 · 86b2c2f · 86b2c2f
1 parent 3c14264
commit 86b2c2f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/lib/needle.js b/lib/needle.js
@@ -489,6 +489,14 @@ Needle.prototype.send_request = function(count, method, uri, config, post_data,
     request.removeListener('error', had_error);
     out.done = true;
 
+    // An error can still be fired after closing.  In particular, on macOS.
+    // Adding an explicit abort() call resolves this without leaving a dangling
+    // listener.  See also:
+    //  - https://github.com/tomas/needle/issues/391
+    //  - https://github.com/less/less.js/issues/3693
+    //  - https://github.com/nodejs/node/issues/27916
+    request.abort();
+
     if (callback)
       return callback(err, resp, resp ? resp.body : undefined);
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "needle",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "description": "The leanest and most handsome HTTP client in the Nodelands.",
   "keywords": [
     "http",