Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Github Actions versions (were using old Node.js versions) #122

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

a-h
Copy link
Contributor

@a-h a-h commented Aug 23, 2024

No description provided.

@a-h a-h requested a review from joerdav as a code owner August 23, 2024 08:31
@joerdav
Copy link
Owner

joerdav commented Aug 23, 2024

Uh oh, new linting rules!

@@ -100,7 +100,9 @@ func (i interpreter) executeShell(
if err != nil {
return fmt.Errorf("failed to parse task: %w", err)
}
if os.Getenv("NO_COLOR") != "1" && term.IsTerminal(int(os.Stdout.Fd())) {
// Ignore G115: Potential integer overflow when converting between integer types
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the nosec line needs be precede the offending line, if I remember correctly!

@joerdav joerdav merged commit b3eb0e1 into joerdav:main Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants