Skip to content

Commit

Permalink
test,tools: enable linting for undefined vars
Browse files Browse the repository at this point in the history
The test directory had linting for undefined variables disabled. It is
enabled everywhere else in the code base. Let's disable the fule for
individual lines in the handful of tests that use undefined variables.

PR-URL: nodejs#6255
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
  • Loading branch information
Trott authored and joelostrowski committed Apr 25, 2016
1 parent 6f92564 commit 767d908
Show file tree
Hide file tree
Showing 13 changed files with 19 additions and 26 deletions.
2 changes: 0 additions & 2 deletions test/.eslintrc
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
## Test-specific linter rules

rules:
## allow undeclared variables
no-undef: 0
## common module is mandatory in tests
required-modules: [2, "common"]

Expand Down
1 change: 1 addition & 0 deletions test/message/nexttick_throw.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ process.nextTick(function() {
process.nextTick(function() {
process.nextTick(function() {
process.nextTick(function() {
// eslint-disable-next-line
undefined_reference_error_maker;
});
});
Expand Down
1 change: 1 addition & 0 deletions test/message/timeout_throw.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
require('../common');

setTimeout(function() {
// eslint-disable-next-line no-undef
undefined_reference_error_maker;
});
2 changes: 1 addition & 1 deletion test/parallel/test-domain-exit-dispose-again.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ setTimeout(function firstTimer() {
// Make V8 throw an unreferenced error. As a result, the domain's error
// handler is called, which disposes the domain "d" and should prevent the
// nested timer that is attached to it from running.
err3();
err3(); // eslint-disable-line no-undef
});
}, TIMEOUT_DURATION);

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-domain-exit-dispose.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function err() {
});

// this function doesn't exist, and throws an error as a result.
err3();
err3(); // eslint-disable-line no-undef
}

function handle(e) {
Expand Down
18 changes: 5 additions & 13 deletions test/parallel/test-exception-handler2.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,14 @@
'use strict';
require('../common');
var assert = require('assert');
const common = require('../common');

process.on('uncaughtException', function(err) {
console.log('Caught exception: ' + err);
});

var timeoutFired = false;
setTimeout(function() {
setTimeout(common.mustCall(function() {
console.log('This will still run.');
timeoutFired = true;
}, 500);

process.on('exit', function() {
assert.ok(timeoutFired);
});
}), 50);

// Intentionally cause an exception, but don't catch it.
nonexistentFunc();
console.log('This will not run.');

nonexistentFunc(); // eslint-disable-line no-undef
common.fail('This will not run.');
6 changes: 4 additions & 2 deletions test/parallel/test-global.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@ var assert = require('assert');

common.globalCheck = false;

baseFoo = 'foo';
baseFoo = 'foo'; // eslint-disable-line no-undef
global.baseBar = 'bar';

assert.equal('foo', global.baseFoo, 'x -> global.x in base level not working');

assert.equal('bar', baseBar, 'global.x -> x in base level not working');
assert.equal('bar',
baseBar, // eslint-disable-line no-undef
'global.x -> x in base level not working');

var module = require('../fixtures/global/plain');
const fooBar = module.fooBar;
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http-exceptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var common = require('../common');
var http = require('http');

var server = http.createServer(function(req, res) {
intentionally_not_defined();
intentionally_not_defined(); // eslint-disable-line no-undef
res.writeHead(200, {'Content-Type': 'text/plain'});
res.write('Thank you, come again.');
res.end();
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-listen-fd-cluster.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ if (common.isWindows) {
switch (process.argv[2]) {
case 'master': return master();
case 'worker': return worker();
case 'parent': return parent();
}

var ok;
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-next-tick-errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ let exceptionHandled = false;
process.nextTick(function() {
order.push('A');
// cause an error
what();
what(); // eslint-disable-line no-undef
});

// This nextTick function should remain in the queue when the first one
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-regress-GH-2245.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ require('../common');
var assert = require('assert');

/*
in node 0.10 a bug existed that caused strict functions to not capture
In Node.js 0.10, a bug existed that caused strict functions to not capture
their environment when evaluated. When run in 0.10 `test()` fails with a
`ReferenceError`. See https://github.com/nodejs/node/issues/2245 for details.
*/
Expand All @@ -21,7 +21,7 @@ function test() {

eval(code);

return bar();
return bar(); // eslint-disable-line no-undef

}

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-timers-reset-process-domain-on-throw.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function err() {

function err2() {
// this function doesn't exist, and throws an error as a result.
err3();
err3(); // eslint-disable-line no-undef
}

function handleDomainError(e) {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-util-inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ errors.forEach(function(err) {
assert.equal(util.inspect(err), err.stack);
});
try {
undef();
undef(); // eslint-disable-line no-undef
} catch (e) {
assert.equal(util.inspect(e), e.stack);
}
Expand Down

0 comments on commit 767d908

Please sign in to comment.