Skip to content

feat(CDP-1451): make explicit nullable type #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2025
Merged

feat(CDP-1451): make explicit nullable type #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f47874
feat(CDP-1451): make explicit nullable type
nemanjajojic Sep 2, 2025
2b07c66
feat(CDP-1451): fix code style
nemanjajojic Sep 4, 2025
fe4ac84
feat(CDP-1451): fix
nemanjajojic Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/ErrorHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

use Buzz\Exception\ClientException;
use Jobcloud\Kafka\SchemaRegistryClient\Exception\BackendDatastoreException;
use Jobcloud\Kafka\SchemaRegistryClient\Exception\ImportException;
use Jobcloud\Kafka\SchemaRegistryClient\Exception\CompatibilityException;
use Jobcloud\Kafka\SchemaRegistryClient\Exception\ImportException;
use Jobcloud\Kafka\SchemaRegistryClient\Exception\IncompatibileAvroSchemaException;
use Jobcloud\Kafka\SchemaRegistryClient\Exception\InvalidAvroSchemaException;
use Jobcloud\Kafka\SchemaRegistryClient\Exception\InvalidVersionException;
Expand All @@ -18,10 +18,10 @@
use Jobcloud\Kafka\SchemaRegistryClient\Exception\UnauthorizedException;
use Jobcloud\Kafka\SchemaRegistryClient\Exception\UnprocessableEntityException;
use Jobcloud\Kafka\SchemaRegistryClient\Exception\VersionNotFoundException;
use JsonException;
use Psr\Http\Client\ClientExceptionInterface;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use JsonException;

class ErrorHandler implements ErrorHandlerInterface
{
Expand All @@ -45,8 +45,11 @@ class ErrorHandler implements ErrorHandlerInterface
* @throws ClientExceptionInterface
* @throws SchemaRegistryExceptionInterface
*/
public function handleError(ResponseInterface $response, string $uri = null, RequestInterface $request = null): void
{
public function handleError(
ResponseInterface $response,
?string $uri = null,
?RequestInterface $request = null
): void {
$responseContent = json_decode($response->getBody(), true, 512, JSON_THROW_ON_ERROR);

if (false === isset($responseContent['error_code'])) {
Expand Down
4 changes: 2 additions & 2 deletions src/ErrorHandlerInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ interface ErrorHandlerInterface
*/
public function handleError(
ResponseInterface $response,
string $uri = null,
RequestInterface $request = null
?string $uri = null,
?RequestInterface $request = null
): void;
}