Karapace 3.3.0 compatibility #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
healerz
suggested changes
Oct 28, 2022
healerz
approved these changes
Oct 28, 2022
Contributor
healerz
left a comment
healerz
left a comment
There was a problem hiding this comment.
Thanks for the PR 🚀
Can you change the target branch to https://github.com/jobcloud/php-kafka-schema-registry-client/tree/fix/karapace3.3.0compatibility so the CI runs before I merge it to main? Or do you know of a neater way? 🙂
Contributor
Author
|
I think there used to be a button run anyway or something like that for external PRs, but not sure 😄 adjusted |
healerz
added a commit
that referenced
this pull request
Oct 28, 2022
* Karapace 3.3.0 compatibility (#18) * add version not found as valid ex * add new test * improvements * fix logic * fix: fix cs Authored by: Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the newest karapace version throws a new additional exception