Skip to content

feat(MPM-553): add missing docblock #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 7, 2022
Merged

feat(MPM-553): add missing docblock #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
158a2f2
feat/MPM-553/add-missing-docblock
ruzakaranbol Nov 29, 2022
4beb840
updated ci config
ruzakaranbol Nov 29, 2022
c3892f0
changed Dockerfile
ruzakaranbol Nov 29, 2022
e781a9b
updated docker image
ruzakaranbol Dec 5, 2022
0cba22c
reverted changes
ruzakaranbol Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2.1

orbs:
ci-caching: jobcloud/[email protected]
ci-php: jobcloud/ci-php@2.4
ci-php: jobcloud/ci-php@2.5

workflows:
test-php-kafka-lib:
Expand Down
7 changes: 2 additions & 5 deletions docker/dev/php/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM php:7.4-cli-alpine3.13
FROM php:7.4-cli-alpine3.16

ARG HOST_USER_ID
ARG HOST_USER
Expand All @@ -10,10 +10,7 @@ COPY files/php/ /phpIni

# SYS: Install required packages
RUN apk --no-cache upgrade && \
apk --no-cache add bash git sudo openssh autoconf gcc g++ make

RUN apk add librdkafka librdkafka-dev \
--update-cache --repository http://dl-3.alpinelinux.org/alpine/edge/community
apk --no-cache add bash git sudo openssh autoconf gcc g++ make librdkafka librdkafka-dev

# we need support for users with ID higher than 65k, so instead of using this:
#RUN adduser -u $HOST_USER_ID -D -H $HOST_USER
Expand Down
6 changes: 6 additions & 0 deletions src/Consumer/KafkaConsumerInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

namespace Jobcloud\Kafka\Consumer;

use Jobcloud\Kafka\Exception\KafkaConsumerConsumeException;
use Jobcloud\Kafka\Exception\KafkaConsumerEndOfPartitionException;
use Jobcloud\Kafka\Exception\KafkaConsumerTimeoutException;
use Jobcloud\Kafka\Message\KafkaConsumerMessageInterface;
use RdKafka\Metadata\Topic as RdKafkaMetadataTopic;
use RdKafka\TopicPartition as RdKafkaTopicPartition;
Expand Down Expand Up @@ -45,6 +48,9 @@ public function isSubscribed(): bool;
* @param integer $timeoutMs
* @param boolean $autoDecode
* @return KafkaConsumerMessageInterface
* @throws KafkaConsumerConsumeException
* @throws KafkaConsumerEndOfPartitionException
* @throws KafkaConsumerTimeoutException
*/
public function consume(int $timeoutMs = 10000, bool $autoDecode = true): KafkaConsumerMessageInterface;

Expand Down