Skip to content

Conversation

@nikolatrajkovic994
Copy link
Contributor

@nikolatrajkovic994 nikolatrajkovic994 commented Sep 25, 2024

feat(CDH-457): revert Dockerfile; downgrade 'infection/infection' in require-dev;

@nikolatrajkovic994
Copy link
Contributor Author

nikolatrajkovic994 commented Sep 26, 2024

Hi, I am opening a follow-up PR, to fix a mistake that I made regarding the raising of the PHP version on Dockerfile.

The issue is that in composer require we have PHP 8.0 requirement and in Dockerfile dev PHP 8.3. This unmatching versions could lead to creating/masking/hiding a bug in next development cycles where the next person might add some package or change that works on PHP 8.3 but not on 8.0 as well.
Now, if you start thinking the other way around, to verify if everything works with higher versions as well you would need to check it locally. But this is a part of a bigger issue, or in other words, this is a sign of the need for matrix build on such libraries.
Currently, with this setup, it is best to test via CircleCI on the lowest possible PHP version.

Big thanks to @nemanjajojic and @komando82 for pointing out the issue!
My bad, and sorry for now requiring extra work here.

Next target release version is v2.4.1

Please let me know if you have any questions.

@nikolatrajkovic994 nikolatrajkovic994 marked this pull request as ready for review September 26, 2024 07:24
@nikolatrajkovic994 nikolatrajkovic994 requested a review from a team as a code owner September 26, 2024 07:24
@nikolatrajkovic994 nikolatrajkovic994 changed the title feat(CDH-457): revert Dockerfile; downgrade 'infection/infection' in … feat(CDH-457): revert Dockerfile Sep 26, 2024
@nemanjajojic
Copy link

nemanjajojic commented Sep 26, 2024

Hi, I am opening a follow-up PR, to fix a mistake that I made regarding the raising of the PHP version on Dockerfile.

The issue is that in composer require we have PHP 8.0 requirement and in Dockerfile dev PHP 8.3. This unmatching versions could lead to creating/masking/hiding a bug in next development cycles where the next person might add some package or change that works on PHP 8.3 but not on 8.0 as well. Now, if you start thinking the other way around, to verify if everything works with higher versions as well you would need to check it locally. But this is a part of a bigger issue, or in other words, this is a sign of the need for matrix build on such libraries. Currently, with this setup, it is best to test via CircleCI on the lowest possible PHP version.

Big thanks to @nemanjajojic and @komando82 for pointing out the issue! My bad, and sorry for now requiring extra work here.

Next target release version is v2.4.1

Please let me know if you have any questions.

yup. without matrix build, releasing libs that support multiple versions of php and packages is really challenging. I know it was on maintenance list we were voting at the beginning to this term, however not sure how it standing in terms of priority.

Truth to be told, we are doing this once in a blue moon, but that do not mean it's not challenging

@nikolatrajkovic994 nikolatrajkovic994 merged commit 675fb60 into main Sep 27, 2024
8 checks passed
@nikolatrajkovic994 nikolatrajkovic994 deleted the feat/CDH-457/revert-dockerfile branch September 27, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants