Skip to content

Conversation

@nick-zh
Copy link
Contributor

@nick-zh nick-zh commented Sep 26, 2022

I would suggest adjusting the previous fix to this, reason being, that the previous logic did:

  • make sure Avro was valid according to the Avro specification
  • make sure we were able to register the schema

The new logic:

  • makes sure we can register the schema
    It also relies that any schema registry variant (official schema registry, karapace, redpanda) adhere to the same avro specs without bugs. This is less save and the additional check should be kept imho

@nick-zh nick-zh requested a review from a team September 26, 2022 15:11
@bajdzun
Copy link
Contributor

bajdzun commented Sep 27, 2022

Closed in favour of PR #43, thanks @nick-zh

@bajdzun bajdzun closed this Sep 27, 2022
@nick-zh nick-zh deleted the improve-fix branch September 27, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants