Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sly-edit-definition-hooks to support mdot-fu contrib. #375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add sly-edit-definition-hooks to support mdot-fu contrib. #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 27 additions & 18 deletions sly.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3922,6 +3922,9 @@ For insertion in the `compilation-mode' buffer"
,(when hints `(:hints ,hints))))


(defvar sly-edit-definition-hooks '()
"The hooks are called with the same arguments as
`slime-edit-definition'.")

(defun sly-edit-definition (&optional name method)
"Lookup the definition of the name at point.
Expand All @@ -3935,24 +3938,30 @@ new frame."
(sly-read-symbol-name "Edit Definition of: "))))
;; The hooks might search for a name in a different manner, so don't
;; ask the user if it's missing before the hooks are run
(let ((xrefs (sly-eval `(slynk:find-definitions-for-emacs ,name))))
(unless xrefs
(error "No known definition for: %s (in %s)"
name (sly-current-package)))
(cl-destructuring-bind (1loc file-alist)
(sly-analyze-xrefs xrefs)
(cond (1loc
(sly-push-definition-stack)
(sly--pop-to-source-location
(sly-xref.location (car xrefs)) method))
((null (cdr xrefs)) ; ((:error "..."))
(error "%s" xrefs))
(t
(sly-push-definition-stack)
(sly-xref--show-results file-alist 'definition name
(sly-current-package)
(cons (selected-window)
method)))))))
(or (run-hook-with-args-until-success 'sly-edit-definition-hooks
name method)
(let ((xrefs (sly-eval `(slynk:find-definitions-for-emacs ,name))))
(sly-edit-definition-cont xrefs
name method))))

(defun sly-edit-definition-cont (xrefs name method)
(unless xrefs
(error "No known definition for: %s (in %s)"
name (sly-current-package)))
(cl-destructuring-bind (1loc file-alist)
(sly-analyze-xrefs xrefs)
(cond (1loc
(sly-push-definition-stack)
(sly--pop-to-source-location
(sly-xref.location (car xrefs)) method))
((null (cdr xrefs)) ; ((:error "..."))
(error "%s" xrefs))
(t
(sly-push-definition-stack)
(sly-xref--show-results file-alist 'definition name
(sly-current-package)
(cons (selected-window)
method))))))

(defvar sly-edit-uses-xrefs
'(:calls :macroexpands :binds :references :sets :specializes))
Expand Down