Prefer projectile if available #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn’t projectile be one implementation of project? You are free to add more onto project-find-functions.
I don’t use projectile, but another project management system, and would rather see a single interface used...
… On Dec 4, 2018, at 7:05 AM, Jimmy Yuen Ho Wong ***@***.***> wrote:
In some situations, especially in the case of a monorepo, there will be a different project under different directories, but all under the same repo. LSP servers tend to be located in these subdirectories as well, but Emacs's built-in project package doesn't seem to recognize these different project types (npm, pip etc...) OOTB, so the servers are unable to launch without some .dir-local mess. This PR attempts to fix that.
Aside: The whole point of project-current seems to be about getting the root of the current project, removing uses project-current will clean up the code somewhat, the downside is eglot 's signature will have to change. Let me know if you'd like to change that.
You can view, comment on, or merge this pull request online at:
#175 <#175>
Commit Summary
Prefer projectile if available
File Changes
M eglot.el <https://github.com/joaotavora/eglot/pull/175/files#diff-0> (33)
Patch Links:
https://github.com/joaotavora/eglot/pull/175.patch <https://github.com/joaotavora/eglot/pull/175.patch>
https://github.com/joaotavora/eglot/pull/175.diff <https://github.com/joaotavora/eglot/pull/175.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#175>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADDtSYR7uJAOxTN9umR88zcrNU9omUBYks5u1nL9gaJpZM4ZAnIk>.
|
|
A dup of #129, which is marked wontfix.
I agree. The author of projectile is presumedly trying to make this even easier. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, especially in the case of a monorepo, there will be a different project under different directories, but all under the same repo. LSP servers tend to be located in these subdirectories as well, but Emacs's built-in project package doesn't seem to recognize these different project types (npm, pip etc...) OOTB, so the servers are unable to launch without some .dir-local mess. This PR attempts to fix that.
Aside: The whole point of
project-currentseems to be about getting the root of the current project, removing usesproject-currentwill clean up the code somewhat, the downside iseglot's signature will have to change. Let me know if you'd like to change that.