remove menu bar and switch to fullscreen as well

[anarcat]

this remembers the previous menu bar setting, but not the full screen
setting.

we therefore assume full screen mode is always off before turning on
darkroom, which may be inaccurate.

we do our best with fullscreen, yet it doesn't always seem to be enough, see:

http://www.emacswiki.org/emacs/FullScreen

... for more information. it may also be useful to consider more frame
parameters, see:

https://www.gnu.org/software/emacs/manual/html_node/elisp/Management-Parameters.html#Management-Parameters

for more ideas. "sticky" strikes me as a possibly good idea.

note that I already sent a similar patch by email before finding this git repository.

[joaotavora]

First of all, thanks for bringing this in as a pull reuqest. I see you had already sent me a mail, but it slipped through my inbox. Sorry about that. I'll have a look.

[anarcat]

thanks, and no trouble for the delay. this is not the same patch as what i sent by email, which had weird issues and didn't remember menubar settings.

[anarcat]

ping?

[joaotavora]

I don't know...

(1) even if you save the initial state of those variables, aren't there cases where you don't to remove those two particular distractions?

(2) Most importantly, the things you are plotting to hide are frame-specific things, not buffer-specific things. So one buffer in darkroom-mode would be responsible for (dramatically) changing the look of every other buffer not in darkroom-mode. How would this work with darkroom-tentative-mode, for instance?

Because of this, I would add a darkroom-clean-frame-mode that removes the menu bar and fullscreens the frame. But this is only a very small saving over calling toggle-frame-fullscreen and menu-bar-mode manually, once per session, which is probably what most users are after.

[anarcat]

well, maybe a different mode would be in order, but to respect POLA, i think frames and menus should be dealt with. It's a major distraction...

[joaotavora]

It's a major distraction...

I agree fully: I have my emacs fullscreened and menu-bar-less most of the time. I use toggle-frame-fullscreen once in a while to turn if off...

But another question is what should M-x darkroom-mode do to with them? What about M-x darkroom-tentative-mode. If the answer to both, after considering the implications, is "hmmm, nothing I guess", then there are, in my view, already commands in the Emacs core to control them, and darkroom.el doesn't need to add them.

[anarcat]

i was hoping to have darkroom as an all-in-one solution, without forcing users to fiddle too much with their .emacs...

[joaotavora]

OK, but have you tried seeing the implications of the code you are proposing? In the current version a buffer can be in darkroom-mode and another buffer not in darkroom-mode. I can switch between those buffers happily, and if I hide the buffer in darkroom-mode it's like I've never activated it at all. In your code it doesn't happen and I suspect it would fail even more tests...

i was hoping to have darkroom as an all-in-one solution, without forcing users to fiddle too much with their .emacs...

Then write anarcatroom-mode based on darkroom-mode, I don't mind :-)

[anarcat]

in rnkn/olivetti#6, i was pointed towards https://github.com/joostkremers/writeroom-mode which answers this requirement. thanks for the responses!

[joaotavora]

I take the opportunity to restate, from the rnkn/olivetti#6 discussion, that @rnkn made the same points I did here. I believe you will run into problems when you want some buffers in writeroom-mode and others not in writeroom-mode. Best of luck anyway.