Skip to content

Fixes: weekend 'today' = Friday's move, clearer wallet cards, mobile forms, sticky tooltips - #40

Merged
joaoguimaraespro merged 1 commit into
mainfrom
fix/weekend-day-change
Oct 4, 2026
Merged

joaoguimaraespro merged 1 commit into
mainfrom
fix/weekend-day-change

Conversation

@joaoguimaraespro

Copy link
Copy Markdown
Owner

Summary

  • Today's change on weekends was 0 € for shares/ETFs. Saturday/Sunday syncs record the unchanged Friday price, so the previous close was Saturday's. DayChange.TradingDay now maps a weekend price date to Friday for non-crypto assets, so the weekend shows Friday's move like broker apps. Crypto keeps its own date. Unit tested.
  • Wallet cards: the line showed "Hoje +0,00 €" next to an unlabelled green "+5,9 %" (the total return), which read like a contradiction. It's now two labelled lines: Hoje € (%) and Retorno %.
  • Forms on phones: .form-grid > .col-span-2 { grid-column: 1 / -1 } lived in @layer utilities. Tailwind's .col-span-2 is emitted unlayered, and unlayered CSS beats layered CSS, so the override never applied. One-column phone forms grew a 0px phantom column that squeezed half the fields: New account (Type, Opening balance, Institution) and every other form using the pattern. The rule now sits outside the layer.
  • Tooltips on touch: a tapped icon button's tooltip stayed on screen (no hover to leave). Tooltips are hidden under (hover: none); icon buttons keep their aria-labels.

Test plan

  • DayChangeTests (weekend → Friday's move; crypto and weekdays unchanged); Investments.Tests green
  • Web unit tests; build
  • Playwright, 390px touch: the account form grid is one 286px column (was 0px 274px), and no tooltip is visible after tapping the header buttons

…ures; one-column forms on phones; no sticky tooltips on touch
@joaoguimaraespro
joaoguimaraespro merged commit 501d689 into main Oct 4, 2026
7 checks passed
@joaoguimaraespro
joaoguimaraespro deleted the fix/weekend-day-change branch October 4, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant