Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update englishDataset phrases #50

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Update englishDataset phrases #50

merged 3 commits into from
Jan 12, 2024

Conversation

HatScripts
Copy link
Contributor

@HatScripts HatScripts commented Jan 8, 2024

Type of change:

  • Refactor
  • Performance improvement
  • New feature
  • Bug fix
  • Other (please describe):

Please describe the changes this PR makes and why it should be merged:

  1. Sorted phrases alphabetically
  2. Add 10 new phrases: bollocks, dyke, kike, negro, piss, prick, spastic, turd, twat, wanker
    (Found at: https://en.wiktionary.org/wiki/Category:English_swear_words)
  3. Update patterns for abbo (now abo), bestiality, and cunt

Status:

  • I've added/modified unit tests relevant to my change / not needed
  • This PR contains breaking changes
  • This PR doesn't include changes to the code

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad51d19) 100.00% compared to head (6303c3d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          505       505           
  Branches        92        92           
=========================================
  Hits           505       505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@jo3-l jo3-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind retargetting this PR to the dev branch? Everything else LGTM, thanks.

@HatScripts HatScripts changed the base branch from main to dev January 12, 2024 02:54
@HatScripts
Copy link
Contributor Author

Would you mind retargetting this PR to the dev branch? Everything else LGTM, thanks.

Done! :)

@jo3-l
Copy link
Owner

jo3-l commented Jan 12, 2024

Thanks, I'll fix the lint issues in a followup commit.

@jo3-l jo3-l merged commit 4653de5 into jo3-l:dev Jan 12, 2024
7 of 9 checks passed
jo3-l added a commit that referenced this pull request Jan 12, 2024
@HatScripts
Copy link
Contributor Author

Any chance of this being added to the main branch?

@jo3-l
Copy link
Owner

jo3-l commented Mar 1, 2024

Thanks for the reminder. I will tag a new release this weekend; sorry for the delay.

jo3-l added a commit that referenced this pull request Mar 3, 2024
@jo3-l
Copy link
Owner

jo3-l commented Mar 3, 2024

Released 0.2.1 on npm, PTAL @HatScripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants