Wu lee/use current compile #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Node 0.8 doesn't build for reasons I confess I don't understand. Specifically, [email protected] and glob@^6.0.4 are valid versions. |
|
strange indeed |
|
I think it is a problem with node v0.8 shipping with an npm which doesn't understand caret versions. PR #29 may fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses couchdb-compile@~1.6.2 as per @argl's original pull request, but also includes a fix to make the tests pass.
I can confirm this version does not have the problem described in #26. Due to deficiencies in NodeJS/nodeunit's
deepEqual()function, I have not written a test which catches that issue, since I am currently unsure of what the best work around would be.