PresenceHandler: Fix exception in _handle_timeouts loop

At this point the user and not the time should be accessed. Fixes matrix-org#3715
jo-so · Mar 25, 2019 · 31c536e · 31c536e
1 parent 064c44e
commit 31c536e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/synapse/handlers/presence.py b/synapse/handlers/presence.py
@@ -365,10 +365,9 @@ def _handle_timeouts(self):
                     if now - last_update > EXTERNAL_PROCESS_EXPIRY
                 ]
                 for process_id in expired_process_ids:
-                    users_to_check.update(
+                    users_to_check.update(self.wheel_timer.fetch(
                         self.external_process_last_updated_ms.pop(process_id, ())
-                    )
-                    self.external_process_last_update.pop(process_id)
+                    ))
 
                 states = [
                     self.user_to_current_state.get(