Fix: URL Encode keys and values in URL encoded form data #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in jnunemaker#687, the existing implementation of our querystring construction was not valid according to the HTTP/1.1 specification, which was noticed with an integration issue with Apache Tomcat. This affects both the generation of Query Strings, and URL encoded form parameters. The solution is to ensure that we always URL-encode the keys, as well as the values. It appears that the existing test we had for this, "returns a Rails style query string", was not actually quite testing what we thought it was, as we had not tested the rendering of the raw values, only the URL decoded ones. Closes jnunemaker#697.
TheSmartnik
approved these changes
Apr 17, 2020
alan-gds
added a commit
to GovWifi/govwifi-admin
that referenced
this pull request
Dec 2, 2020
This required changing some test expectations, because httparty now encodes keys in query parameters. jnunemaker/httparty#698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #687, the existing implementation of our querystring
construction was not valid according to the HTTP/1.1 specification,
which was noticed with an integration issue with Apache Tomcat.
This affects both the generation of Query Strings, and URL encoded form
parameters.
The solution is to ensure that we always URL-encode the keys, as well as
the values.
It appears that the existing test we had for this, "returns a Rails
style query string", was not actually quite testing what we thought it
was, as we had not tested the rendering of the raw values, only the URL
decoded ones.
Closes #697.