-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multipart support #569
Add multipart support #569
Conversation
Neat. I really don't know much about multipart uploads, but this seems simple and contained so I'm going to merge it. @TheSmartnik are you ok with me pinging you in the future if questions or other pull requests come up about this? |
@jnunemaker sure, I'd be super happy to help |
This implementation is broken – header The problem is that |
@jirutka oh, I see. Thanks a lot for feedback and pr |
May be worth emphasizing for many folks that decided to use |
httparty now supports multipart uploads, see jnunemaker/httparty#569
httparty now supports multipart uploads, see jnunemaker/httparty#569
Hi,
This pull request fixes long-standing issue, of not handling file upload properly #52. No extra dependencies introduced. Tested file upload on rails server, works alright.